[vlc-devel] [PATCH] Qt: Don't emit statusChanged multiple times

[Jakob Leben]

On Thu, Feb 25, 2010 at 3:13 PM, Srikanth Raju <srikiraju at gmail.com> wrote:

> Hello,
> The statusChanged() signal is being emitted twice on play and pause.
>


> @@ -103,7 +103,6 @@ void InputManager::setInput( input_thread_t *_p_input )
>      {
>          msg_Dbg( p_intf, "IM: Setting an input" );
>          vlc_object_hold( p_input );
> -        emit statusChanged( PLAYING_S );
>          UpdateName();
>          UpdateArt();
>          UpdateTeletext();
> @@ -693,7 +692,6 @@ void InputManager::togglePlayPause()
>          int state = var_GetInteger( p_input, "state" );
>          state = ( state != PLAYING_S ) ? PLAYING_S : PAUSE_S;
>          var_SetInteger( p_input, "state", state );
> -        emit statusChanged( state );
>      }
>  }
>
>
It is clear to me why not emitting statusChanged in  togglePlayPause(), but
why not in setInput()? Removing the signal only from togglePlayPause() fixes
the problem for me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100308/82864adc/attachment.html>