[vlc-devel] [PATCH] Qt: Don't emit statusChanged multiple times

[Jakob Leben]

On Mon, Mar 8, 2010 at 10:28 AM, Srikanth Raju <srikiraju at gmail.com> wrote:

> On Mon, Mar 8, 2010 at 2:47 PM, Jakob Leben <jakob.leben at gmail.com> wrote:
> >
> >
> > It is clear to me why not emitting statusChanged in  togglePlayPause(),
> but
> > why not in setInput()? Removing the signal only from togglePlayPause()
> fixes
> > the problem for me.
> >
>
> I get PLAYING_S -> OPENING_S -> PLAYING_S as status changes with the
> emit in setInput(). Removing the emit removes the first PLAYING_S.
>
>
I applied your patch with some modifications in setInput() that ensure
PLAYING_S does always get emitted (simply removing the emition of signal
might miss the input status change to PLAYING_S if it happens before Qt
callbacks are connected) .

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100308/fe5ab4b5/attachment.html>