[vlc-devel] [vlc-commits] commit: Qt: Playlist drag and drop corrections (Jakob Leben )

Rémi Denis-Courmont remi at remlab.net
Mon Mar 8 13:48:22 CET 2010

On Mon, 8 Mar 2010 12:56:30 +0100, Jakob Leben <jakob.leben at gmail.com>

> Previously, the drag data consisted of PLItem *, which is the worst
> option,
> since they might be freed while dragging.
> Do you agree then on using playlist_item_t *? Those are never freed until
> the playlist is, but we can check if they are still in the
> playlist_t->all_items array.

How about NOT trusting the core playlist to work around limitations in your
Qt playlist model?

> Unfortunately, we cannot use input_item_t*, because if we incref them, I
> don't see any way in Qt to make sure they are decrefed after drag
> operation.

You can probably wrap the input_item_t reference in a QObject that Just
Does The Right Thing Somehow(tm)(c)(R).

Rémi Denis-Courmont

More information about the vlc-devel mailing list