[vlc-devel] GSOC Audio filters-patch-001

[Christophe Mutricy]

On Tue, Mar 30, 10 at 22:26 +0800, wangxiang wrote:

> From c9050afc826a9b20ebfa0d5a34700a422375b54d Mon Sep 17 00:00:00 2001
> From: richard <xwang at xwang-laptop.(none)>
Set correctly Git with your Full name and a proper emai address       

> Date: Tue, 30 Mar 2010 22:09:57 +0800
> Subject: [PATCH] from xiangwang <wangxiang68 at gmail.com>

Proper commit message is needed.

> +/*****************************************************************************
> + * headphone.c: The filter make it more comfortable to listen to headphones
> + *****************************************************************************
> + * VideoLAN

Copyright and year is needed.

> +static block_t *DoWork(filter * p_filter, block_t * p_in_buf)
> +{
> +    if(aout_FormatNbChannels(&p_filter->fmt_in.audio)!=2)
> +	return p_in_buf; /*******Only Work For Two Channels**********/

Souldn't it be tested in Open() ?

And it's missing a module declaration and a Close() and the buildsystem
modification

-- 
Xtophe