[vlc-devel] RE :: skins2(Linux): add WM_CLASS and _NET_WM_PID properties to skins2 windows (Erwan Tulou )
brezhoneg1 at yahoo.fr
Mon May 3 13:56:26 CEST 2010
> On Mon, 3 May 2010 11:13:42 +0200 (CEST), git at videolan.org wrote:
> > + // initialize EWMH pid
> > + pid_t pid = getpid();
> > + XChangeProperty( XDISPLAY, m_wnd, NET_WM_PID, XA_CARDINAL, 32,
> > + PropModeReplace, (unsigned char *)&pid, 1 );
> Isn't the PID supposed to use the server byte order?
EWMH specs don't seem to mention the server byte order as a requirement.
Do you have any specs that say so ?
But, specs mention WM_CLIENT_MACHINE as a requirement when _WM_NET_PID
is present, which I forgot to add.
(Another patch is needed)
As for backporting to vlc1.1, I think it is desirable.
More information about the vlc-devel