[vlc-devel] [vlc-commits] commit: Win32: hack^Wfix opening UNC paths (fixes #3459) ( Rémi Denis-Courmont )

Pierre Ynard linkfanel at yahoo.fr
Sun May 9 10:45:08 CEST 2010


> -        if( psz_path[0] != '/'
> -#if (DIR_SEP_CHAR != '/')
> -            /* We accept invalid URIs too. */
> -            && psz_path[0] != DIR_SEP_CHAR
> -#endif
> -          )
> +        if( psz_path[0] != '/' )

Any reason that would prevent from following the robustness principle?

> +        else
> +            /* Strip leading slash in front of the drive letter */
> +            psz_path++;
> +#endif
>          /* Then URI-decode the path. */
>          decode_URI( psz_path );
> -#if defined( WIN32 ) && !defined( UNDER_CE )
> -        /* Strip leading slash in front of the drive letter */
> -        psz_path++;
> -#endif

Any reason why leading slashes should now be stripped on WinCE (where
there are no drive letters, and leading slashes are just part of the
path) ?

Regards,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."



More information about the vlc-devel mailing list