[vlc-devel] [PATCH 3/3] Added livehttp access_out module to support HTTP Live Streaming

[Ilkka Ollakka]

On Tue, Mar 30, 2010 at 11:00:32PM -0400, Keary Griffin wrote:

Hi,

few small marks, as I didn't spot anyone else yet mentioning them.

> +static ssize_t Read ( sout_access_out_t *, block_t * );

> +    p_access->pf_read  = Read;

No need to define Read at all, as core checks if it's defined before
using.

> +#ifdef WIN32
> +static int convert_path ( const char *restrict path, wchar_t *restrict wpath )
> +static int win32_replace_rename ( const char *oldpath, const char *newpath )
> +static int win32_retry_rename( const char *oldpath, const char *newpath )

Maybe these should be in core instead access_output ? seems kinda
generic functions. Didn't check if courmisch allready merged them in.

> +    if ( p_sys->i_numsegs == 0 )
> +        i_firstseg = 1;
> +    else
> +        i_firstseg = ( p_sys->i_segment >= p_sys->i_numsegs ) ? ( ( p_sys->i_segment - p_sys->i_numsegs ) + 1 ) : 1;

Wouldn't this be simpler if you just extend first if to check if
i_segments < i_umsegs too?

-- 
Ilkka Ollakka
Q:  How many Zen masters does it take to screw in a light bulb?
A:  None.  The Universe spins the bulb, and the Zen master stays out
    of the way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100510/98fd0ab6/attachment.sig>