[vlc-devel] [PATCH 1/5] Select wrapper video output if --vout is specified on Mac OS

[Rémi Denis-Courmont]

On Mon, 10 May 2010 15:32:01 -0700, David Menestrina <dmenest-vlc at ofb.net>
wrote:
> ---
>  src/video_output/video_output.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/src/video_output/video_output.c
> b/src/video_output/video_output.c
> index 859bdb4..7da99a9 100644
> --- a/src/video_output/video_output.c
> +++ b/src/video_output/video_output.c
> @@ -464,6 +464,14 @@ vout_thread_t * vout_Create( vlc_object_t *p_parent,
> video_format_t *p_fmt )
>      if( !p_vout->p->psz_filter_chain || !*p_vout->p->psz_filter_chain )
>      {
>          psz_parser = NULL;
> +#ifdef __APPLE__
> +        // On Mac OS, the wrapper video output module has lower
> precedence
> +        // than the opengl module.  So if a vout is requested, we must
> +        // select the wrapper video output module.
> +        char *voutstr = var_CreateGetNonEmptyString( p_vout, "vout" );
> +        if( voutstr )
> +            psz_parser = strdup( "vout_wrapper" );

Doesn't this break in case of --vout=opengl ?

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis