[vlc-devel] [vlc-commits] commit: qt4: set empty choice as default in preferences if there is one ( Ilkka Ollakka )

[Jean-Baptiste Kempf]

On Sat, May 15, 2010 at 06:17:15PM +0200, git at videolan.org wrote :
> vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Sat May 15 19:17:08 2010 +0300| [902605baeaab7e80eab202d132af559ef4df6be2] | committer: Ilkka Ollakka 
> 
> qt4: set empty choice as default in preferences if there is one
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=902605baeaab7e80eab202d132af559ef4df6be2
> ---
> 
>  modules/gui/qt4/components/preferences_widgets.cpp |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/modules/gui/qt4/components/preferences_widgets.cpp b/modules/gui/qt4/components/preferences_widgets.cpp
> index eb36b32..83602c0 100644
> --- a/modules/gui/qt4/components/preferences_widgets.cpp
> +++ b/modules/gui/qt4/components/preferences_widgets.cpp
> @@ -519,6 +519,7 @@ void StringListConfigControl::finish(module_config_t *p_module_config, bool byca
>          if( !p_module_config->ppsz_list[i_index] )
>          {
>                combo->addItem( "", QVariant(""));
> +              combo->setCurrentIndex( combo->count() - 1 );

I believe this is a bit annoying... Couldn't you do a lookup on "" ?
findText() ?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/