[vlc-devel] [PATCH 1/5] Select wrapper video output if --vout is specified on Mac OS

[Laurent Aimar]

Hi,

On Mon, 2010-05-10 at 15:32 -0700, David Menestrina wrote:
>      if( !p_vout->p->psz_filter_chain || !*p_vout->p->psz_filter_chain )
>      {
>          psz_parser = NULL;
> +#ifdef __APPLE__
> +        // On Mac OS, the wrapper video output module has lower precedence
> +        // than the opengl module.  So if a vout is requested, we must
> +        // select the wrapper video output module.
> +        char *voutstr = var_CreateGetNonEmptyString( p_vout, "vout" );
> +        if( voutstr )
> +            psz_parser = strdup( "vout_wrapper" );
> +#endif
 You are missing a free( voutstr ).

 What are the vout for macosx (ie the ones NOT using vout wrapper) ?
 If there is only a few of them, it would be safer to check for them
here and avoid changing psz_parser.
 Or maybe using some module_* functions to check for capabilities might
be better, but I don't know the module_* API enough.

Regards,

-- 
fenrir