[vlc-devel] [PATCH 3/3] Added livehttp access_out module to support HTTP Live Streaming

[Ilkka Ollakka]

Hi,

As it's been somewhat quiet with this patch regarding rejecting it. I'm
ok to merge it in without those win32-file thinggies, as it seems to be
the point that people have opinions and no clear agreement. It seems to
be iffy on working in windows anyway on file-accessing point of view
with any of those methods ?

So if you could send new patch without those ifdef WIN32 stuff ?

On Mon, May 10, 2010 at 06:52:53PM +0300, Ilkka Ollakka wrote:
> On Tue, Mar 30, 2010 at 11:00:32PM -0400, Keary Griffin wrote:

> > +#ifdef WIN32
> > +static int convert_path ( const char *restrict path, wchar_t *restrict wpath )
> > +static int win32_replace_rename ( const char *oldpath, const char *newpath )
> > +static int win32_retry_rename( const char *oldpath, const char *newpath )

> Maybe these should be in core instead access_output ? seems kinda
> generic functions. Didn't check if courmisch allready merged them in.

> > +    if ( p_sys->i_numsegs == 0 )
> > +        i_firstseg = 1;
> > +    else
> > +        i_firstseg = ( p_sys->i_segment >= p_sys->i_numsegs ) ? ( ( p_sys->i_segment - p_sys->i_numsegs ) + 1 ) : 1;

> Wouldn't this be simpler if you just extend first if to check if
> i_segments < i_umsegs too?
-- 
Ilkka Ollakka
Mustgo, n.:
	Any item of food that has been sitting in the refrigerator so
long it has become a science project.
		-- Sniglets, "Rich Hall & Friends"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100523/a47c1cd9/attachment.sig>