[vlc-devel] [PATCH] rtp sout: don't add a=rtcp: in SDP if RTP port is not specified

[Rémi Denis-Courmont]

Le mardi 25 mai 2010 10:01:48 Pierre Ynard, vous avez écrit :
> diff --git a/modules/stream_out/rtp.c b/modules/stream_out/rtp.c
> index 2199469..94977ea 100644
> --- a/modules/stream_out/rtp.c
> +++ b/modules/stream_out/rtp.c
> @@ -831,7 +831,8 @@ char *SDPGenerate( sout_stream_t *p_stream, const char
> *rtsp_url ) id->psz_enc, id->i_clock_rate, id->i_channels, id->psz_fmtp);
> 
> -        if( !p_sys->rtcp_mux && (id->i_port & 1) ) /* cf RFC4566 §5.14 */
> +        /* cf RFC4566 §5.14 */
> +        if( inclport && !p_sys->rtcp_mux && (id->i_port & 1) )
>              sdp_AddAttribute ( &psz_sdp, "rtcp", "%u", id->i_port + 1 );
> 
>          if( rtsp_url != NULL )
> 
> 
> Regards,

Seems good to me

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis