[vlc-devel] [PATCH] Added livehttp access_out module to support HTTP Live Streaming

[Rémi Denis-Courmont]

Le mercredi 26 mai 2010 18:33:00 Keary Griffin, vous avez écrit :
> +#define SOUT_CFG_PREFIX "sout-livehttp-"
> +#define SEGLEN_TEXT N_("Segment length")
> +#define SEGLEN_LONGTEXT N_("Length of ts stream segments")

Capitalize TS.

> +#define SPLITANYWHERE_TEXT N_("Split segments anywhere")
> +#define SPLITANYWHERE_LONGTEXT N_("Don't require a keyframe before
> splitting "\ +                                "a segment. Neede for audio
> only.")

Typo "needed".

> +#define NUMSEGS_TEXT N_("Number of segments")
> +#define NUMSEGS_LONGTEXT N_("Number of segments to include in index")
> +
> +#define INDEX_TEXT N_("Index file")
> +#define INDEX_LONGTEXT N_("Path to the index file to create")
> +
> +#define INDEXURL_TEXT N_("Full url to put in index file")
> +#define INDEXURL_LONGTEXT N_("Full url to put in index file. "\
> +                          "Use #'s to represent segment number")

Capitalize URL.

> +    p_access->pf_write = Write;
> +    p_access->pf_seek  = Seek;
> +    p_access->pf_control = Control;
> +    if( !( p_sys = malloc ( sizeof( *p_sys ) ) ) )
> +        return VLC_ENOMEM;

Generally, I prefer the callbacks being set after all error cases. This 
reduces the chance of weird bugs if another plugin is used in case of error.

> +        if ( asprintf( &psz_idxTmp, "%s%s", p_sys->psz_indexPath,
> TMP_IDX_SUFFIX ) < 0)

How about simply 'asprintf( ..., "%s.tmp", ... )' ?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis