[vlc-devel] [vlc-commits] commit: Revert "Added Qt::Tool flag on the fullscreen widget." ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

Le dimanche 30 mai 2010 21:39:13 Laurent Aimar, vous avez écrit :
> On Sun, 2010-05-30 at 21:18 +0300, Rémi Denis-Courmont wrote:
> > Le dimanche 30 mai 2010 21:12:15 Laurent Aimar, vous avez écrit :
> > > On Sun, 2010-05-30 at 17:02 +0200, git at videolan.org wrote:
> > > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun
> > > > May 30 17:59:31 2010 +0300|
> > > > [985a8c9ef8b62b3237fd49a1b620d79fa221d305] | committer: Rémi
> > > > Denis-Courmont
> > > > 
> > > > Revert "Added Qt::Tool flag on the fullscreen widget."
> > > > 
> > > > This reverts commit a91750568de08cd94738e8692420ddc4b2088f5c.
> > >  
> > >  Great, now when I go to fullscreen:
> > >  - I have a useless new window in my task bar. I can't do anything with
> > > 
> > > it, and when I select select the qt4 interface, I doesn't pop up anyway
> > > (same as before). It also makes cycling through windows longer due to
> > > this useless window.
> > 
> > That's a feature. You get the exact same behaviour with the non embedded
> > video.
> 
>  A useless window in the task bar is a feature, right. How stupid of me
> to not have seen it.

I think I explained several times why it was useful.

>  And I don't want the same behaviour than non embed video, as I have
> asked for an embed video, otherwise what's the point?

How is that relevant to fullscreen mode?

>  Besides, it's not coherent with what other video players do (totem and
> smplayer for linux at least).

The fact is that your change broke not only my setup but several other 
testers. I got at least two complaints pinpointing your very commit. And 
considering the limited amount of people tracking master, and the even smaller 
amount of people who would bother to bisect, that's quite bad. And then, the 
Tool flag simply breaks fullscreen with the always-on-top fixes.

I don't really care whether pagers list the video window or not. But 
fullscreen mode has to work at all, and the main UI has to be selectable. 
There may be some way to unlist the video but your commit clearly was not 
right.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis