[vlc-devel] [vlc-commits] commit: Revert "Added Qt::Tool flag on the fullscreen widget." ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

Le dimanche 30 mai 2010 21:42:47 Laurent Aimar, vous avez écrit :
> On Sun, 2010-05-30 at 21:29 +0300, Rémi Denis-Courmont wrote:
> > Le dimanche 30 mai 2010 21:12:15 Laurent Aimar, vous avez écrit :
> > > On Sun, 2010-05-30 at 17:02 +0200, git at videolan.org wrote:
> > > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun
> > > > May 30 17:59:31 2010 +0300|
> > > > [985a8c9ef8b62b3237fd49a1b620d79fa221d305] | committer: Rémi
> > > > Denis-Courmont
> > > > 
> > > > Revert "Added Qt::Tool flag on the fullscreen widget."
> > > > 
> > > > This reverts commit a91750568de08cd94738e8692420ddc4b2088f5c.
> > >  
> > >  Great, now when I go to fullscreen:
> > >  - I have a useless new window in my task bar. I can't do anything with
> > > 
> > > it, and when I select select the qt4 interface, I doesn't pop up anyway
> > > (same as before). It also makes cycling through windows longer due to
> > > this useless window. The name of this widget is not constant, being
> > > 'vlc' the first time and 'Untitled window' the other times.
> > 
> > Well, xprop shows the name is always vlc. Also the command and class are
> > set, which allows any remotely sane WM to group windows properly in the
> > task bar.
> 
>  It does not here, the first time I have:
> WM_NAME(STRING) = "vlc"
> WM_LOCALE_NAME(STRING) = "en_US"
> WM_CLASS(STRING) = "vlc", "Vlc"
> and the second time:
> WM_NAME(STRING) =
> WM_LOCALE_NAME(STRING) = "en_US"
> WM_CLASS(STRING) = "vlc", "Vlc"
> (and it's the same for the icon).

I have them all the time. So it smells a lot like a bug in your (old?) Qt4 
version or perhaps a race in the VLC code. Window flags are totally irrelevant 
here.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis