[vlc-devel] [PATCH 1/4] Base Media Library Module files

[Srikanth Raju]

Hello,
I've attached an improved patch.

On Mon, Oct 18, 2010 at 12:18 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Mon, Oct 18, 2010 at 01:09:21AM +0530, Srikanth Raju wrote :
> > +#define EXTENSIONS_AUDIO_CSV "a52", "aac", "ac3", "ape", "dts", "flac",
> "it", \
> > +                         "m4a", "m4p", "mka", "mlp", "mod", "mp1",
> "mp2", "mp3",\
> > +                         "oga", "ogg", "oma", "s3m", "spx" \
> > +                         "wav", "wma", "wv", "xm"
> > +
> > +#define EXTENSIONS_VIDEO_CSV "asf", "avi", "divx", "dv", "flv", "gxf",
> "iso", \
> > +                             "m1v", "m2v", "m2t", "m2ts", "m4v", "mkv",
> "mov",\
> > +                             "mp2", "mp4", "mpeg", "mpeg1", \
> > +                             "mpeg2", "mpeg4", "mpg", "mts", "mxf",
> "nuv", \
> > +                             "ogg", "ogm", "ogv", "ogx", "ps", \
> > +                             "rec", "rm", "rmvb", "ts", "vob", "wmv"
>
> Why again a list of extensions?
> Why in #define too?
>
>
This is to guess the type of a given media, without having the read the file
itself.


2010/10/19 Rémi Denis-Courmont <remi at remlab.net>
>
> * Using var_Create where not useful.

I don't understand why it's not useful...?

* I can't even find the thread function. Does this code links at all??
>
No! Please look at the other 3 patches for the rest of the functions! This
module isn't enabled in configure.ac, so it won't break anything.

* The big IF_CMP/ELSE_CMP list should be replaced with a static mapping
> table
> and a binary search. It would also remove the need for the huge switch.
>
I don't see how the switch can be removed without having lots of setter
functions.

-- 
Regards,
Srikanth Raju
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101101/ee8bd999/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Base-Media-Library-Module-files.patch
Type: text/x-patch
Size: 64357 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101101/ee8bd999/attachment.bin>