[vlc-devel] [vlc-commits] commit: GME: fix linking on Win32 (Jean-Baptiste Kempf )

[Rémi Denis-Courmont]

Le mardi 2 novembre 2010 15:48:01 git at videolan.org, vous avez écrit :
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Tue Nov  2
> 14:47:32 2010 +0100| [c46366ce7b2f16f1c5e9efb4cd132538c7fd758b] |
> committer: Jean-Baptiste Kempf
> 
> GME: fix linking on Win32
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c46366ce7b2f16f1c5
> > e9efb4cd132538c7fd758b
> 
> ---
> 
>  configure.ac |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index e194780..1bb335e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2302,7 +2302,11 @@ AC_ARG_ENABLE(gme,
>    [  --enable-gme            Game Music Emu support (default auto)])
>  AS_IF([test "${enable_gme}" != "no"], [
>    AC_CHECK_HEADER([gme/gme.h], [
> -    VLC_ADD_LIBS([gme], [-lgme])
> +    if test "${SYS}" = "mingw32"; then
> +        VLC_ADD_LIBS([gme], [-lgme -lstdc++])
> +    else
> +        VLC_ADD_LIBS([gme], [-lgme])
> +    fi

Is this sufficient? AFAIK, we should rather use the CXX linker than manually 
link with stdc++. Adding a dummy.cpp empty fils in the source list of the 
plugin in case HAVE_WIN32 should do the trick.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
..