[vlc-devel] Fix a potential buffer overflow in the samba access

Ludovic Fauvet etix at l0cal.com
Tue Nov 2 19:34:07 CET 2010


2010/11/2 Rémi Denis-Courmont <remi at remlab.net>:
>> Patch #0001 fixes a potential buffer overflow (Win32 only) on a call
>> to snprintf.
>
> snprintf() writes n bytes *including* the terminating nul.
> This patch looks totally useless.

Right.
I didn't read the man carefully, I guessed that the terminal nul byte
wasn't written if the input string was truncated by snprintf.

Sorry for the noise :-)

-- 
Ludovic Fauvet (etix)



More information about the vlc-devel mailing list