[vlc-devel] Fix a potential buffer overflow in the samba access

Pierre Ynard linkfanel at yahoo.fr
Tue Nov 2 20:50:20 CET 2010

> > I didn't read the man carefully, I guessed that the terminal nul
> > byte wasn't written if the input string was truncated by snprintf.
>  On win32, _snprintf is not a valid c99 snprintf, where the return
> value is not the same and the terminating nul character is not present
> when the string is truncated.
>  But VLC does not define snprintf to _snprintf on win32 (but I am not
> sure who actually defines it).

IIRC it would be MinGW. From configure.ac:

    dnl force use of mingw provided c99 *printf over msvcrt

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list