[vlc-devel] [PATCH] qt4: Add OpenBSD to supported platforms of the towlower function.

[Juho Vähä-Herttua]

3.11.2010 10:15, Juho Vähä-Herttua kirjoitti:
> 1) Assume that towlower supports UCS (which it should anyway, since 
> it's supposed to represent a superset of all supported charsets) and 
> risk breaking on 0x80 <= c <= 0xff characters in the worst case.
> 2) Add a manual mapping of ISO 8859-1 characters outside of ASCII 
> range, should work fine for all encodings
> 3) Continue like before and add exceptions for each platform missing 
> __STDC_ISO_10646__. Note that in this case it might be left unknown if 
> the platform _actually_ supports ISO 10646, because many platforms are 
> closed source. Also the status of UCS support might change depending 
> on the libc version and checking it compile time doesn't feel right.
> 4) Simply drop the latin1 support in key events altogether

As one more possible option, wouldn't it work just to remove the "qtk <= 
0xff" shortcut altogether and always do the bsearch over keys array? It 
might be slightly less efficient, but would get rid of this whole mess.


Juho