[vlc-devel] [PATCH] qt4: Add OpenBSD to supported platforms of the towlower function.

[Rémi Denis-Courmont]

   Hello,

On Wed, 3 Nov 2010 19:26:44 -0400, Brad <brad at comstyle.com> wrote:
> On Wednesday 03 November 2010 02:16:42 Rémi Denis-Courmont wrote:
>> ----- Message d'origine -----
>>
>> > OpenBSD has towlower() but does not currently define
> __STDC_ISO_10646__.
>>
>> Is this not a bug in OBSD libc?
> 
> Well most likely. But that doesn't help when I want to compile VLC now
> with current versions instead of months later when and if it is fixed

Yet merging this patch puts no friendly pressure on OpenBSD to get fixed. I
do expect that kind of mistakes from commercial Unices Designed in
California.
But as a distribution that prides itself on correctness, should OpenBSD not
be held to higher standards?

> (I don't know enough about __STDC_ISO_10646__ yet to know if it makes
> sense just defining it now or if it might get us into more trouble
> if we're not hitting a certain threshold for C99 support).

In the event that defining the constant would violate the standard, your
patch would be semantically incorrect. I mean it wouldn't work at run-time.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis