[vlc-devel] [PATCH] p2p-streaming module for VLC

Rémi Denis-Courmont remi at remlab.net
Thu Nov 4 21:04:10 CET 2010


Le lundi 1 novembre 2010 21:47:12 David Fuhrmann, vous avez écrit :
> We sent a link for download, because it is quite big. But okay, I attach it
> if you want so.

The use of singletons all over the place is suspicious. How is re-entrancy 
handled?

I spot thirty two thread creations, yet not a single mutex. This is odd.

And then, we do not allow fixed msleep(), at least not within loops. This 
interferes with CPU idle.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list