[vlc-devel] [PATCH] p2p-streaming module for VLC

[David Fuhrmann]

Hello,

Am 04.11.2010 um 16:00 schrieb Rémi Duraffort:
> If I understand correctly your patch, the p2p mecanisme is also part of
> the patch ? Why not creating a seperate library with and API and create
> a VLC access module that will link and use this library ?

Our initial conditions included that it should be an plugin only for vlc, therefore we had no need to create an external library. All code is in this one patch.


Am 04.11.2010 um 21:04 schrieb Rémi Denis-Courmont:
> The use of singletons all over the place is suspicious. How is re-entrancy 
> handled?

Sorry, what do you mean exactly?

> I spot thirty two thread creations

That is wrong. We only create 4 threads at startup, not more.

> yet not a single mutex. This is odd.

The class DataStore saves all data, which should be accessible in all threads. As only one thread (controllerThread) writes on these values, we saw no need to use mutexes.

> And then, we do not allow fixed msleep(), at least not within loops.

We need to do some actions periodically, so we used msleep(). What else could be used with the same effect?

Greetings, 
David Fuhrmann