[vlc-devel] commit: contrib: Remove the TOOLS hack for darwin. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Fri, Nov 5, 2010 at 2:24 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> On Wed, 3 Nov 2010 12:28:25 +0100
> Rafaël Carré <rafael.carre at gmail.com> wrote:
>
>> It's true that removing a hack is improving things (I hadn't seen the
>> cyclic dependancy when i committed this but i had noticed it after and
>> jones' make seemed to do the right thing)
>>
>> In this specific case though it's reintroducing the problem first
>> reported by you: that concurrent make jobs can break the build if
>> packages are built before their tool dependancy
>
> Pierre, please revert the commit
>
>> btw the tools needed to build contribs are "only" libtool and perhaps
>> 'intl':
>>
>> - (more recent than provided by the system) autoconf/automake are not
>>   needed by contribs, only vlc
>> - yasm is only needed by a few packages (x264/libvpx) so it can be
>>   removed from distribution/*.mak and be an explicit dep
>>
>> So that'll leave probably only libtool
>>
>> Making extras/contrib a real package manager looks like a hard job to
>> solve a simple task instead of just making sure that libtool is the
>> first target to be built
>
> I didn't go very far: gettext is needed both as a 3rd party library
> (libintl) and as a build tool (autopoint), so without a better solution
> just revert this commit

ok. I'll change how it works a bit as well:

add a "buildtools: $(TOOLS)" target to contrib-src.mak, then add to
contrib.mak "make -C src buildtools" before "make -C src". That way it
will be synchronous, and we won't force buildtools to be run for every
individual targets. How does this sounds?

Pierre.