[vlc-devel] [PATCH] access/http: avoid endless loop when connection is lost while reading ICY metadata

[Sven Petai]

hi,

The first attached patch fixes endless loop that is encountered when the 
connection to the shoutcast server is lost while reading ICY metadata block.

Problem arises from the fact that in this case access/http's Read() 
method returned -1 which couple of layers up is read by 
AStreamRefillStream() which just retries right away in that case which 
leads to endless Read() calls.

Second patch is just a readability cleanup that makes the meaning of 
that return value clearer which should help to avoid similar bugs in the 
future.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Return-fatal-error-to-the-upper-layers-when-connecti.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101106/e8437666/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Make-returning-fatal-error-from-the-Read-more-obviou.patch
Type: text/x-patch
Size: 2699 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101106/e8437666/attachment-0001.bin>