[vlc-devel] [PATCH] transcode: Fix multithreaded encoding

[Ilkka Ollakka]

On Mon, Nov 08, 2010 at 04:34:29PM +0100, Rafaël Carré wrote:
> Le 08/11/2010 15:59, Rafaël Carré a écrit :

> >      id->p_encoder->i_threads = p_sys->i_threads;
> >+    /* We pass down the number of desired threads to the encoder (avcodec/x264)
> >+     * But why would we want to run encoder asynchronously to the decoder ?? */
> >+    p_sys->i_threads = 0;

> Note, this patch is functionally equivalent to removing all the
> "if(thread >= 1)" code and EncoderThread().

Like mentioned in IRC, I'm more in favor of removing if(thread > 0 ) and
EncoderThread() alltogether, as it would clean up the code. It's
unlikely anyway that someone would fix current threading code in
transcode.

> I just thought this smaller patch would help looking at the issue :)


-- 
Ilkka Ollakka
What good is a ticket to the good life, if you can't find the
entrance?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101108/360d0b8a/attachment.sig>