[vlc-devel] [PATCH] Add http-referrer option to HTTP access module

[Kaarlo Räihä]

2010/11/12 Jonas Gehring <jonas.gehring at boolsoft.org>

> On 11/12/2010 12:55 AM, Jean-Baptiste Kempf wrote:
> > On Fri, Nov 12, 2010 at 12:51:11AM +0100, Jonas Gehring wrote :
> >> Thanks, I missed the comments on change_safe(). I moved the option
> >> definition outside of the change_safe() scope. The revised patch is
> >> attached.
> >
> > I believe change_safe is per option.
>
> Hm, could you suggest a more appropriate place for the option?
>

I think J-B means that it should look something like:
add_integer( "http-caching", 4 * DEFAULT_PTS_DELAY / 1000, CACHING_TEXT,
CACHING_LONGTEXT, true )
change_safe()
add_string( "http-referrer", NULL, NULL, NULL, false )
change_safe()
add_string( "http-user-agent", NULL, NULL, NULL, false )
change_safe()

So your current patch turns http-caching non-safe since the http-referrer is
inserted between two connected elements.

_______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101112/d1d40353/attachment.html>