[vlc-devel] [PATCH] Add http-referrer option to HTTP access module

Jean-Baptiste Kempf jb at videolan.org
Sun Nov 14 00:48:37 CET 2010


On Fri, Nov 12, 2010 at 11:51:08PM +0100, Jonas Gehring wrote :
> Kaarlo Räihä <kaarlo.raiha at gmail.com> wrote:
>> I think J-B means that it should look something like:
>> add_integer( "http-caching", 4 * DEFAULT_PTS_DELAY / 1000, CACHING_TEXT,
>> CACHING_LONGTEXT, true )
>> change_safe()
>> add_string( "http-referrer", NULL, NULL, NULL, false )
>> change_safe()
>> add_string( "http-user-agent", NULL, NULL, NULL, false )
>> change_safe()
>>
>> So your current patch turns http-caching non-safe since the http-referrer is
>> inserted between two connected elements.
>
> I see, the change_*() macros affect the previous option. I've changed
> the option declaration according to your suggestion (patch attached).

Seems fine.
Any other comments?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734



More information about the vlc-devel mailing list