[vlc-devel] [PATCH] x264: write first SEI NAL into first picture

[Rafaël Carré]

On Sun,  7 Nov 2010 18:55:58 +0100
Rafaël Carré <rafael.carre at gmail.com> wrote:

> It contains the x264 version info and options used for encoding
> If we let it in extradata it will not be present in the final file
> 
> libavcodec does that already, and this makes it easier to compare x264
> options used by VLC and FFmpeg.
> 
> Comparing FFmpeg and VLC with the exact same set of options might help
> finding why mpeg (at least mpeg2/mpeg4/flv) encoding is 5 times slower
> with vlc than with ffmpeg, supposedly for the same set of options.
> 
> ---
> 2nd version of this patch fixes a double free
> 3rd version of this patch includes:
>     - changes for better clarity
>     - assert() that x264 headers contain at most 1 SEI nal
>     - insert the SEI just before the first SLICE nal

ping,

i think it's good now so i'll push it in 2 days unless someone has
another concern

-- 
✍ Rafaël Carré ☺
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101116/4c3043fc/attachment.sig>