[vlc-devel] [PATCH 1/2] Sepia video filter

[Jean-Paul Saman]

Nice work.

On Wed, Nov 17, 2010 at 8:47 AM, Branko Kokanovic
<branko.kokanovic at gmail.com> wrote:
> Hi all,
> attached is the first part of the sepia video filter, ready for review.
> You can also see and read how it looks here[1]. Hope you like it, tell
> me if you find something wrong with it!

Some comments:

+vlc_module_begin ()
+    set_description( N_("Sepia video filter") )
+    set_shortname( N_("Sepia" ) )
+    set_help( N_("Gives video a warmer tone by applying sepia effect") )
+    set_category( CAT_VIDEO )
+    set_subcategory( SUBCAT_VIDEO_VFILTER )
+    set_capability( "video filter2", 0 )
+    add_integer_with_range( CFG_PREFIX "intensity", 30, 0, 255, NULL,
+                           SEPIA_INTENSITY_TEXT, SEPIA_INTENSITY_LONGTEXT,
+                           false )

Indent add_integer_with_range() for readability.

+    set_callbacks( Create, Destroy )
+vlc_module_end ()

kind regards,

Jean-Paul Saman