[vlc-devel] [PATCHv2] Fix input variables

[Laurent Aimar]

Hi,

On Wed, Nov 24, 2010 at 11:20:50AM +0100, Pierre Ynard wrote:
> > On Wed, Nov 24, 2010 at 09:15:30AM +0100, Pierre Ynard wrote:
> > > The input resources create a dedicated parent object, and input
> > > variables are parsed and set on this object too.
> >  I don't think it is the job of the input_resource_t to do that, but
> > of the one creating an input.
> >  For example, in the current code, the parent wanted for normal
> > playback is probably the playlist.
> >  So if I understand your issue, you just need to create an parent
> > object per input in VLM and that should be enough.
> 
> Well I was trying to fix the general case, and it seemed to me that some
> dedicated object would be needed in any case, so I thought it would be
> better not to repeat that logic everywhere.
 I think we may need an object for handling some variables that should stay valid
*across* inputs and provides some helpers (like the rate callback, etc) if we want
to avoid duplicating code between libvlc and playlist (maybe vlm, not sure).

 But your approach does not seems to have this goal at all, so:

> The point of that extra object is to hold input variables
 Why? What is excatly your need? (I think there is an misunderstanding
somewhere...)

-- 
fenrir