[vlc-devel] [PATCH] Support DVD LPCM encode

Steinar H. Gunderson sgunderson at bigfoot.com
Fri Oct 1 02:24:52 CEST 2010


On Mon, Sep 27, 2010 at 11:49:38PM +0200, Steinar H. Gunderson wrote:
> +        p_block->i_dts = p_block->i_pts = p_aout_buf->i_pts +
> +            (i * p_sys->i_frame_samples + i_start_offset) * CLOCK_FREQ / p_sys->i_rate;
> +        p_block->i_length = p_sys->i_frame_samples * CLOCK_FREQ / p_sys->i_rate;

It seems this is not correct wrt. roundoff, and that I should use date_*
instead. I guess I'll have to dig into it tomorrow.

> The format comments are out of sync with what the code actually
> assumes. I updated the comments, and filled in some missing information from
> http://www.mpucoder.com/DVD/ass-hdr.html .

I see this was actually committed; thanks.

/* Steinar */
-- 
Homepage: http://www.sesse.net/



More information about the vlc-devel mailing list