[vlc-devel] [vlc-commits] commit: stream_filter/httplive.c: HTTP Live Streaming (Jean-Paul Saman )
jpsaman at gmail.com
Wed Oct 13 09:48:16 CEST 2010
On Wed, Oct 13, 2010 at 12:50 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Tue, Oct 12, 2010 at 10:07:21PM +0200, git at videolan.org wrote :
>> vlc | branch: master | Jean-Paul Saman <jean-paul.saman at m2x.nl> | Tue Sep 14 20:42:30 2010 +0200| [1723efcc374b22d54896b16ee0fb168018864d37] | committer: Jean-Paul Saman
>> stream_filter/httplive.c: HTTP Live Streaming
>> Support HTTP Live Streaming as described in the IETF draft standard:
>> * http://tools.ietf.org/html/draft-pantos-http-live-streaming-04#page-8
>> and Apple its description:
>> * http://developer.apple.com/library/ios/#documentation/networkinginternet/conceptual/streamingmediaguide/Introduction/Introduction.html#//apple_ref/doc/uid/TP40008332-CH1-DontLinkElementID_29
> Really cool stuff! This is a cool addition to VLC.
> Questions and nitpicking:
> - How can we test it? Sample streams?
> - Was it compiled on linux only?
yes, but should work on windows too (This is next on my list for testing).
> - I was wondering if you could pack hls_stream_s a bit more, by aligning
> it a bitmore ? same for hls_thread_t?
I will look into it.
> - Why are you using sometimes int, sometimes uint64_t for bw ?
that needs correcting
> - in AccessOpen(), isn't the if (p_sys->p_access) whith the big brace
> (l.910) returning VLC_ENOMEM the contrary to the habits we have in VLC?
> wouldn't if( !p_sys->p_access) return VLC_ENOMEM look more classic?
> - Shouldn't some functions be flagged as const?
> - What is the protocol to detect bw_up and bw_down? Was that not too
> difficult with VLC arch?
It is fairly simple, measure the download speed per segment and base a
decision on that.
Since the stream_filter initiates the download itself it can also
measure how long that takes and
calculate the average download speed in terms of bandwidth of the stream.
> - Can't you remove #include <vlc_input.h>, <vlc_fs.h>, <vlc_network.h>,
> it compiled here without them :D
> Harder question:
> - How is this linked to TS files? Meaning would that work with an
> adaptive stream of webm files?
The standard is written for MPEG-TS and MP3 files, but the
stream_filter is agnostic to content.
> Thanks for the cool work.
> Jean-Baptiste Kempf
> +33 672 704 734
More information about the vlc-devel