[vlc-devel] [PATCH] input: Fill in the input_item es.

Laurent Aimar fenrir at elivagar.org
Sun Oct 17 13:47:25 CEST 2010


Hi,

On Sun, Oct 17, 2010 at 01:59:18PM +0300, Rémi Denis-Courmont wrote:
> Le dimanche 17 octobre 2010 13:48:24 Jean-Baptiste Kempf, vous avez écrit :
> > On Sun, Oct 17, 2010 at 10:53:37AM +0200, Rafaël Carré wrote :
> > > +/* Stripped down version of es_format_t because es_format_t can become
> > > very + * large in term of memory. This is exactly
> > > libvlc_media_track_info_t */
> > 
> > Maybe, but I would argue AR infos are missing, and so do FourCC.
> 
> And SPU language ISO code.
 If all that is wanted, then it would be better to directly store the
es_format. By removing the current text description that we already
add (in another path), it should not use more memory (the GUI will
need to do it itself). Not copying the es_format_t::p_extra could
also be a good idea.

-- 
fenrir




More information about the vlc-devel mailing list