[vlc-devel] commit: libvlc_video_*: rewrite ( Rémi Denis-Courmont )

[Rafaël Carré]

On Mon,  1 Feb 2010 18:50:28 +0100 (CET)
git at videolan.org (git version control) wrote:

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon
> Feb  1 19:47:45 2010 +0200|
> [bdab92b9d508e438c1fe9a94402829f9a790f12e] | committer: Rémi
> Denis-Courmont 
> 
> libvlc_video_*: rewrite
> 
>  - enable (non-ES) settings even if no output is present
>  - best effort at handling multiple outputs
>  - remove exceptions
>  - libvlc_video_get_size returns both dimensions
>  - libvlc_video_take_snapshot takes a parameter to select the output
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bdab92b9d508e438c1fe9a94402829f9a790f12e

...

> -void
> -libvlc_video_take_snapshot( libvlc_media_player_t *p_mi, const char *psz_filepath,
> -        unsigned int i_width, unsigned int i_height, libvlc_exception_t *p_e )
> +int
> +libvlc_video_take_snapshot( libvlc_media_player_t *p_mi, unsigned num,
> +                            const char *psz_filepath,
> +                            unsigned int i_width, unsigned int i_height )
>  {

...

> -    var_TriggerCallback( p_vout, "video-snapshot" );
> -    vlc_object_release( p_vout );

you are now leaking the p_vout reference

> +    var_TriggerCallback (p_vout, "video-snapshot" );
> +    return 0;
>  }

-- 
✍ Rafaël Carré ☺
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101025/4beda2eb/attachment.sig>