[vlc-devel] [PATCH] Extend libvlc Media Player API for DVD menu navigation

[Arnaud VALLAT]

2010/9/8 Rémi Denis-Courmont <remi at remlab.net>:
>
> Nit picking...
>
> On Wed,  8 Sep 2010 22:25:55 +0200, Arnaud Vallat <rno.rno at gmail.com>
> wrote:
>> +/**
>> + * Navigate through DVD Menu
>> + *
>> + * \param p_mi the Media Player
>> + * \param i_navigate the Navigation mode
>> + */
>
> The \version stanza is missing.

Which version should I put?

>
>> +void libvlc_media_player_navigate( libvlc_media_player_t* p_mi,
>> +                                int i_navigate )
>
> 'unsigned' would be simpler.
>
>> +{
>> +    input_thread_t *p_input_thread;
>> +
>> +    if ( i_navigate < 0 || i_navigate > libvlc_navigate_right)
>> +      return;
>
> sizeof(libvlc_navigate_to_action) / sizeof(libvlc_navigate_to_action[0])
> would reduce the chance of bugs if the enumeration is ever extended.
>
> Best regards,
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net
> http://fi.linkedin.com/in/remidenis
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 

  "Given enough eyeballs, all bugs are shallow"
    Eric Steven Raymond