[vlc-devel] [PATCH] adding posterize video filter

[Jean-Baptiste Kempf]

Hello,

On Sat, Sep 11, 2010 at 06:49:03PM +0200, Branko Kokanovic wrote :
> I implemented posterize filter (in attachment). It works with planar and
> packed YUV and RGB24/32 formats. Output is the same as Gimp's
> "Posterize" functionality. I wrote one filter before[1], but this one
> should also go to a review. Only thing I'm not satisfied with is that I
> implemented my own functions for RGB<->YUV conversion, but since I asked
> here that before[2] and no one replied, I didn't had much choice.
> Thanks in advance for reviewing/applying to master.

Thanks for the work.

> ---
>  modules/video_filter/Modules.am  |    2 +
>  modules/video_filter/posterize.c |  514 ++++++++++++++++++++++++++++++++++++++

missing NEWS, po/POTFILES.in and modules/LIST modifications

> +    switch( p_filter->fmt_in.video.i_chroma )
> +    {
> +        case VLC_CODEC_RGB24:
> +			break;
no tab in source, please

> +/*****************************************************************************
> + * Destroy: destroy Mirror video thread output method
> + *****************************************************************************
> + * Terminate an output method created by MirrorCreateOutputMethod
> + *****************************************************************************/

> +/*****************************************************************************
> + * Render: displays previously rendered output
> + *****************************************************************************
> + * This function send the currently rendered image to Mirror image, waits
> + * until it is displayed and switch the two rendering buffers, preparing next
> + * frame.
> + *****************************************************************************/

Mirror?


The code compiles fine for Linux and Win32 here,btw.


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734