[vlc-devel] fixing a bug: preferred audio language select for .ogg

[Jean-Baptiste Kempf]

On Wed, Sep 15, 2010 at 06:51:40PM -0500, Karl Ostmo wrote :
> Yes, in all of the .ogg files I've seen, the language attributes look
> like this: "LANUGAGE=English" or "LANGUAGE=Japanese".  In
> vorbis_ParseComment() (defined in vlc/modules/demux/vorbis.h), I added
> another case:
>         else IF_EXTRACT("LANGUAGE=", Language )
Oh, my...

Do you have samples to share?

> and added Language as another enum value.  Also, I added a vlc_meta_t
> *p_meta member to the logical_stream_s struct in modules/demux/ogg.h,
> as it was previously only in the demux_sys_t struct.  Calling
> vorbis_ParseComment() with &p_stream->p_meta as the first argument
> stores the appropriate language metadata in each stream separately.
Ok.

> With these modifications, the language string can later be retrieved
> with vlc_meta_Get(p_stream->p_meta, vlc_meta_Language).  I am unsure
> how to accomplish all of this from within Ogg_ReadVorbisHeader(),
> however.
Ask ogg.k.ogg.k or salsaman, they might know.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734