[vlc-devel] [PATCH] access module for BlackMagic SDI cards
Steinar H. Gunderson
sgunderson at bigfoot.com
Tue Sep 28 00:32:20 CEST 2010
On Mon, Sep 27, 2010 at 02:32:02PM +0200, Jean-Baptiste Kempf wrote:
>> In any case, I guess this would break the Windows build currently (if the
>> user has the SDK installed), so I don't think it's an unreasonable default.
> Very unlikely case.
OK, changing the default to enabled.
>>> Is this necessary ?
>> Yes, it is, given that the module is C++ and the INT64_C stuff is C99.
Dealing with this in one of the next e-mails.
>> Does VLC have incremental inc and dec functions I could use?
> vlc_gc_incref and such? Not sure if that applied here.
There's seemingly <vlc_atomic.h>; I've converted to using that function.
>> Please explain (or point to an example). I have no idea how this stuff works :-)
> Ivoire will comment more.
Punting to his e-mail.
>> releases in some path. I wonder if the cleanest thing is to put _everything_
>> in Close(), even though, say, p_display_iterator is never used outside of
>> Open(). What would you prefer -- a goto or putting stuff in Close()?
> I don't care. Choose what is better, but don't copy-paste error pathes
> in code.
OK, my favourite solution would be RAII, but I'm not starting to make that
kind of support for a project that's primarily C.
I've refactored into the goto solution. It's a bit better, although more
>> Do you want me to reword the message?
Could not start streaming from SDI card. This could be caused by invalid
video mode or flags, access denied, or card already in use.
>> Updated patch below.
> Formatted git patch, please.
Will send at end of the e-mail chain (there are more things to deal with
/* Steinar */
More information about the vlc-devel