[vlc-devel] [PATCH] decode an RTP/H264 elementary stream without using SDP

[Rémi Denis-Courmont]

On Wed, 29 Sep 2010 09:18:34 +0200, Tony Vankrunkelsven
<Tony.Vankrunkelsven at otnsystems.com> wrote:
>> Isn't that "unknown" path impossible? I would rather have an assertion
>> here. Trying the "unknown" demuxer is not going to be any good.
> 
> Normally the "unknown" path is impossible since there are currently some
> 'if' statements before demux_init is called. It is added just in case
> demux_init is used and "demux->psz_demux" is not specified.

> I've check this path with some test code 
> and the result is that no demux module can be found.

That hides a bug and will make our life more miserable if we need to debug
it.
Please don't do that.

>> Isn't that statement redundant with regards to the following strcmp()s?
> 
> The 'if' statement could be seen as redundant. But if "demux->psz_demux"
> is not specified it looks better not to do the strcmp()s.

This generates useless code and adds unnecessary indentation.

> Also more strcmp()s might be added in the future.

So what?

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis