[vlc-devel] [PATCH 1/2] Sepia improve by being done in YUV

[Branko Kokanovic]

On 09.04.2011. 20:05, Jean-Baptiste Kempf wrote:
>> On Thu, Apr 07, 2011 at 11:58:12PM +0200, gamajun at seznam.cz wrote :
>>> Bring major speed up for most videos
> 
> Applied.
> 
> Best Regards,
> 

Sorry for late answer. This patch is actually not optimization, it's a
completely different algorithm for calculating sepia. As far as I'm
concerned, it's good enough to be applied as it is, just a couple of
notes, you can, but don't have to take into account:
* Martin, I'm really interested about your algorithm for YUV sepia
conversion, is there any references, maybe they should also be somewhere
in comment if they exist?
* Maybe default value for intensity should be bigger - people will
probably experiment with filters and we want to make good first
impression. With your algorithm, I got best result with 130-150, 100 was
too small (ok, this is mostly personal opionion only!)
* Intensity values->RGB conversion you do in RVSepia() function should
use yuv_to_rgb() function from filter_picture.h. It's really cleaner and
easier to maintain then for every video filter to have it's own
conversion functions)

As I already said - if we omit my third note, patch is great as it is
and should be applied. It is different algorithm, but much, much faster!

Greetings, Kokan