[vlc-devel] karaoke filter

[郭宇宏]

Thank you.

I'll change the filter and send the patch to vlc-devel.

The (filter_t *p_filter = (filter_t*)p_this;)  should not be freed by me.

2011/4/10 Jean-Baptiste Kempf <jb at videolan.org>

> On Sat, Apr 09, 2011 at 08:26:35PM +0800, 郭宇宏 wrote :
> >  * Edit By YuHong
>
> Please use author and mention the port from mplayer.
>
> > vlc_module_begin ()
> >     set_description( N_("karaoke audio filter") )
> >     set_shortname( N_("karaoke af") )
> >     set_category( CAT_AUDIO )
> >     add_shortcut( "karaoke" )
> >     set_capability( "audio filter", 0 )
> >     set_callbacks( Open, Close )
> > vlc_module_end ()
>
> Missing set_subcategory( SUBCAT_AUDIO_AFILTER )
>
> >     /* filter calculation */
> >     for( i = 0; i < i_samples; i++) {
> You can declare int i directly in the for
>
> >  **********************************************************************/
> > static void Close( vlc_object_t *p_this )
> > {
> >     filter_t *p_filter = (filter_t*)p_this;
> >     free(p_filter);
>
> Are you sure this is yours to free it?
>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110410/6a8b2b80/attachment.html>