[vlc-devel] [PATCH 1/2] Sepia improve by being done in YUV

Gamajun at seznam.cz Gamajun at seznam.cz
Tue Apr 12 21:43:18 CEST 2011

Thanks for the ping and sorry for late answer.

>> * Intensity values->RGB conversion you do in RVSepia() function should
>> use yuv_to_rgb() function from filter_picture.h. It's really cleaner and
>> easier to maintain then for every video filter to have it's own
>> conversion functions)
> That is a fair point. Martin?
Well, I considered this, but in the matter of speed, this solution is a lot
faster, because it doesn't have to count the values for U and V channels,
as these are constant. However, it's really messy and I think, it can be
cleaned up, not speaking about possibility of SIMD speeding up.

> * Martin, I'm really interested about your algorithm for YUV sepia
> conversion, is there any references, maybe they should also be somewhere
> in comment if they exist?
The formula I used is mentioned in comments above calculations. There are
no references, as I managed to invent it myself, based on the pieces of
information I found around the web (and mainly on your work). I didn't
achieve the same result, as I thought it would be better, if user was
allowed to change strenght of the effect directly from B&W scale.

And to the intensity, you are right, higher values are better... maybe
those 130... I'll see I'll do anything about it next time, or somebody  

More information about the vlc-devel mailing list