[vlc-devel] karaoke filter

[郭宇宏]

Yes, i check the problem of the filter.

And i made a new patch of the filter *karaoke and sweep.*

2011/4/11 Ilkka Ollakka <ileoo at videolan.org>

> On Sat, Apr 09, 2011 at 08:26:35PM +0800, 郭宇宏 wrote:
> > I'm VideoLan gsoc 2011 student yuhong.
>
> Hi,
>
> > This is the filter porting from Mplayer.
>
>
> >     /* filter calculation */
> >     for( i = 0; i < i_samples; i++) {
> >         for( i_chan = 0; i_chan < i_channels; i_chan++ ) {
> >            p_in_buf[i] = (p_in_buf[i] - p_in_buf[i+1]) * 0.7;
> >            p_in_buf[i+1] = p_in_buf[i];
> >         }
> >     }
>
> Why do you loop over i_channels but don't use i_chan for anything
>
>
> --
> Ilkka Ollakka
> Slang is language that takes off its coat, spits on its hands, and goes
> to work.
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110414/05a24d1b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-karaoke-and-sweep-audio-filters.patch
Type: text/x-patch
Size: 10024 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110414/05a24d1b/attachment.bin>