[vlc-devel] [PATCH] Correct scroll effect and clearing in TV+Graphics decoder

Jean-Baptiste Kempf jb at videolan.org
Fri Aug 5 12:19:09 CEST 2011


'lo,

On Wed, Aug 03, 2011 at 04:29:56PM +0100, Kym Greenshields wrote :
> The changes above to the unsigned appear to have been introduced after
> the release of 1.1.11 stable. I personally prefer that they remain
> signed as this serves to re-inforce that the screen is being rotated +/-
> offsets.

I don't think this is relevant to the patch then.

> Again - personal preference.

Then, I am sorry, this shouldn't be in the patch.

Please try to have patches with 1 feature per patch, so that people
reviewing can actually review them. Else, it is a bit too
hard/confusing...

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list