[vlc-devel] [PATCH] libass: message callback, improved logging

[Mathieu Velten]

ASS_Library which contains the message_callback member is freed, so it
should work if this is not cached somewhere else.

I will do some tests tonight, my last test on that was before the summer,
the libass vlc code has changed quite a bit since then.

I also have a patch which add srt parsing to the libass renderer (using
parsing code from mplayer) : it allows to handle correctly all the TAG srts
out there by converting "standard" HTML-like tags into ass tags.

I will review my code and post that later this week.
It should be quite stable since it is sitting and working on my desk for
nearly one year... Each time I said myself "I am going to send that this
week" I find some stuffs that I don't like in my code when reviewing it,
make some changes and loose focus :P

Mathieu Velten

Le 21 août 2011 13:49, Rémi Denis-Courmont <remi at remlab.net> a écrit :

> Le dimanche 21 août 2011 14:40:58 Mathieu Velten, vous avez écrit :
> > Hi,
> >
> > Just want to raise a warning here : I tried that too, and I used to have
> > segfault sometimes when quitting vlc or stopping playback because the
> > callback is sometimes called after p_dec was freed.
>
> Isn't ass_library_done() supposed to undo ass_set_message_cb implicitly?
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110821/3bfc91a2/attachment.html>