[vlc-devel] [PATCH] Support static modules using extern NULL-terminated list

[Rémi Denis-Courmont]

On Mon, 22 Aug 2011 18:54:25 -0400, Rafaël Carré <rafael.carre at gmail.com>
wrote:
> diff --git a/src/modules/bank.c b/src/modules/bank.c
> index b001d1b..07c2b7f 100644
> --- a/src/modules/bank.c
> +++ b/src/modules/bank.c
> @@ -91,6 +91,14 @@ void module_InitBank (void)
>          module_t *module = module_InitStatic (vlc_entry__main);
>          if (likely(module != NULL))
>              module_StoreBank (module);
> +#ifndef HAVE_DYNAMIC_PLUGINS

Why is that?

> +       extern vlc_plugin_cb *vlc_static_modules;

Shouldn't this rather be a weak symbol ?



-- 
Rémi Denis-Courmont
http://www.remlab.net/