[vlc-devel] [vlc-commits] block_t ** parameter is never NULL for audio?decoding

[Laurent Aimar]

On Thu, Aug 25, 2011 at 10:29:29PM +0300, Rémi Denis-Courmont wrote:
> Le jeudi 25 août 2011 21:52:34 Laurent Aimar, vous avez écrit :
> > Hi,
> > 
> > On Thu, Aug 25, 2011 at 07:08:26PM +0200, Rémi Denis-Courmont wrote:
> > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Aug 25
> > > 18:54:04 2011 +0300| [48e39d4453616f2b41a55405e11b41407e0b3222] |
> > > committer: Rémi Denis-Courmont
> > > 
> > > block_t ** parameter is never NULL for audio decoding
> > 
> >  I think it will be when packetizer/decoder flushing will finally
> > be integrated (I need to find a bit of time to review the last
> > round of patches).
> 
> Wouldn't it be easier (for plugins) to have a dedicated 
> pf_eos/pf_flush/whatever optional callback?
 For the core, not really because calling pf_decode/pf_flush should
be done at the same place.
 For plugin, no idea. I think it depends on the decoder. At least, some
will use the same code path (and so pf_flush is more complex, like
avcodec),

-- 
fenrir