[vlc-devel] [vlc-commits] vlc_CPU_init: factorize altivec check by using asm input

[Rafaël Carré]

Le Fri, 26 Aug 2011 08:41:53 +0200,
Rémi Denis-Courmont <remi at remlab.net> a écrit :

> On Fri, 26 Aug 2011 06:23:44 +0200 (CEST), git at videolan.org (Rafaël
> Carré) wrote:
> > @@ -257,10 +257,6 @@ out:
> >  # if defined (__ARM_NEON__)

__ARM_NEON__ is defined here

> >      i_capabilities |= CPU_CAPABILITY_NEON;
> >  # elif defined (CAN_COMPILE_NEON)

So here __ARM_NEON__ is not defined and CAN_COMPILE_NEON is

> > -#  define NEED_RUNTIME_CPU_CHECK 1
> > -# endif
> > -
> > -# ifdef NEED_RUNTIME_CPU_CHECK
> 
> WTH is this?

hm? just look at *all* the other capabilities check in this file.

#if defined(XXX)
    /* assume extension is available */
#elif defined(CAN_COMPILE_XXX)
    /* runtime check */
#endif

> >  #  if defined (__linux__)
> >      FILE *info = fopen ("/proc/cpuinfo", "rt");
> >      if (info != NULL)
> > @@ -274,11 +270,11 @@ out:
> >  
> >               if (strncmp (line, "Features\t:", 10))
> >                   continue;
> > -#   if defined (CAN_COMPILE_NEON) && !defined (__ARM_NEON__)
> > +
> 
> And this too???

"So here __ARM_NEON__ is not defined and CAN_COMPILE_NEON is"

> >               cap = strstr (line + 10, " neon");
> >               if (cap != NULL && (cap[5] == '\0' || cap[5] == ' '))
> >                   i_capabilities |= CPU_CAPABILITY_NEON;
> > -#   endif
> > +
> 

-- 
Rafaël Carré