[vlc-devel] [PATCH] contrib: --disable-all doesn't build anything

[Rafaël Carré]

Le Thu, 1 Dec 2011 22:46:18 +0200,
"Rémi Denis-Courmont" <remi at remlab.net> a écrit :

> Le jeudi 1 décembre 2011 22:30:53 Rafaël Carré, vous avez écrit :
> > possibly we could use more categories
> > 
> > everything is such a category
> 
> Only if categories are nested.
> 
> Bluntly, I think disable-all is useless. If you want 'make all' not to do 
> anything, then don't run it! If you don't want automatic detection, then you 
> can simply run 'make .foo .bar'.

true i could use that, doing the selection at boostrap only requires me to type 'make' though

> > > But if you removed all of that, it's not really VLC anymore. I don't
> > > think we want to promote that sort of sub-standard builds.
> > 
> > Well that's my problem. VLC is modular, I take advantage of that, and
> > still call it VLC.
> > 
> > Is VLC without sout still VLC? Despite the L for LAN ?
> > 
> > Is VLC without disc support still VLC? Despite that libdvdcss was
> > authored at VideoLAN?
> 
> VLC without discs on a device that does not have a disc player is not 
> something that is going to disappoint the user base.
> 
> VLC without synthesis or picture viewing will not disappoint many people 
> because it is rarely used for this.

VLC without contribs whitelisting is disappointing myself

> > > And removing LUA and XML is not serious.
> > 
> > I have no use for XML or lua and i'm not sure why it's not serious
> 
> They affect playlists and they don't really depend on anything. I don't see 
> the point of removing them.

i'm not going to open playlists for now

> Certainly for deeply embedded applications, you will want to select every 
> dependency one by all. But then, you will probably integrate VLC into a wider 
> build system, so it is questionable whether contribs even make sense.

That wider build system could use contrib as-is

> Is this really what you're trying to do, or is this just a facade to make it 
> easier to make a substandard form of what an full Android port ought to be?

it's a nice first step towards a full Android port

-- 
Rafaël Carré